"Perhaps a short inside..."? Probably not a short circuit, more likely an open circuit, caused by intermittent connections.

Besides the suggestion of the flash tube and dry cells being aged, another common component that degrades with age are electrolytic capacitors, which are used in flash circuits to store the charge as it builds up.